mbox series

[0/2] fix segfault seen with performance-thread example

Message ID 1563205172-352-1-git-send-email-erik.g.carrillo@intel.com (mailing list archive)
Headers
Series fix segfault seen with performance-thread example |

Message

Carrillo, Erik G July 15, 2019, 3:39 p.m. UTC 
  A crash occurs in the examples/performance-thread/l3fwd-thread when it calls
into rte_timer_manage() from the LThread library it utilizes.  This happens
because the application omitted a call to rte_timer_subsystem_init(), which
leaves a pointer set to null in the timer library.  This pointer is
dereferenced in a check for validity of a timer data object, resulting in
the segfault.  This series fixes the validity check in the timer library,
and adds the missing call to rte_timer_subsystem_init in the application.

Erik Gabriel Carrillo (2):
  timer: fix null pointer dereference
  examples/performance-thread: init timer subsystem

 examples/performance-thread/l3fwd-thread/main.c | 5 +++++
 lib/librte_timer/rte_timer.c                    | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon July 18, 2019, 9:20 p.m. UTC | #1 
15/07/2019 17:39, Erik Gabriel Carrillo:
> A crash occurs in the examples/performance-thread/l3fwd-thread when it calls
> into rte_timer_manage() from the LThread library it utilizes.  This happens
> because the application omitted a call to rte_timer_subsystem_init(), which
> leaves a pointer set to null in the timer library.  This pointer is
> dereferenced in a check for validity of a timer data object, resulting in
> the segfault.  This series fixes the validity check in the timer library,
> and adds the missing call to rte_timer_subsystem_init in the application.
> 
> Erik Gabriel Carrillo (2):
>   timer: fix null pointer dereference
>   examples/performance-thread: init timer subsystem

Applied, thanks