mbox series

[v1,0/9] drivers/baseband: new PMD for ACC101 device

Message ID 1649106828-116338-1-git-send-email-nicolas.chautru@intel.com (mailing list archive)
Headers
Series drivers/baseband: new PMD for ACC101 device |

Message

Chautru, Nicolas April 4, 2022, 9:13 p.m. UTC 
  This serie introduces the PMD for the new bbdev device ACC101
(aka Mount Cirrus). This is a derivative from previous Mount Bryce
which includes silicon improvement, bug fixes, capacity improvement
for 5GNR and feature improvement.


Nicolas Chautru (9):
  baseband/acc101: introduce PMD for ACC101
  baseband/acc101: add HW register definition
  baseband/acc101: add info get function
  baseband/acc101: add queue configuration
  baseband/acc101: add LDPC processing
  baseband/acc101: support HARQ loopback
  baseband/acc101: support 4G processing
  baseband/acc101: support MSI interrupt
  baseband/acc101: add device configure function

 MAINTAINERS                              |    3 +
 app/test-bbdev/meson.build               |    3 +
 app/test-bbdev/test_bbdev_perf.c         |   69 +
 doc/guides/bbdevs/acc101.rst             |  237 ++
 doc/guides/bbdevs/features/acc101.ini    |   13 +
 doc/guides/bbdevs/index.rst              |    1 +
 doc/guides/rel_notes/release_22_07.rst   |    4 +
 drivers/baseband/acc101/acc101_pf_enum.h | 1128 ++++++++
 drivers/baseband/acc101/acc101_vf_enum.h |   79 +
 drivers/baseband/acc101/meson.build      |    8 +
 drivers/baseband/acc101/rte_acc101_cfg.h |  113 +
 drivers/baseband/acc101/rte_acc101_pmd.c | 4457 ++++++++++++++++++++++++++++++
 drivers/baseband/acc101/rte_acc101_pmd.h |  631 +++++
 drivers/baseband/acc101/version.map      |   10 +
 drivers/baseband/meson.build             |    1 +
 15 files changed, 6757 insertions(+)
 create mode 100644 doc/guides/bbdevs/acc101.rst
 create mode 100644 doc/guides/bbdevs/features/acc101.ini
 create mode 100644 drivers/baseband/acc101/acc101_pf_enum.h
 create mode 100644 drivers/baseband/acc101/acc101_vf_enum.h
 create mode 100644 drivers/baseband/acc101/meson.build
 create mode 100644 drivers/baseband/acc101/rte_acc101_cfg.h
 create mode 100644 drivers/baseband/acc101/rte_acc101_pmd.c
 create mode 100644 drivers/baseband/acc101/rte_acc101_pmd.h
 create mode 100644 drivers/baseband/acc101/version.map

Comments

Thomas Monjalon April 5, 2022, 6:48 a.m. UTC | #1 
04/04/2022 23:13, Nicolas Chautru:
> This serie introduces the PMD for the new bbdev device ACC101
> (aka Mount Cirrus). This is a derivative from previous Mount Bryce
> which includes silicon improvement, bug fixes, capacity improvement
> for 5GNR and feature improvement.

Nack for adding this driver.
Afer comparing with A100 driver, it is clear that it can be merged
in the same driver.
Bug fixes and improvements are not justification to create a new driver.
David Marchand April 5, 2022, 6:57 a.m. UTC | #2 
On Tue, Apr 5, 2022 at 8:48 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 04/04/2022 23:13, Nicolas Chautru:
> > This serie introduces the PMD for the new bbdev device ACC101
> > (aka Mount Cirrus). This is a derivative from previous Mount Bryce
> > which includes silicon improvement, bug fixes, capacity improvement
> > for 5GNR and feature improvement.
>
> Nack for adding this driver.
> Afer comparing with A100 driver, it is clear that it can be merged
> in the same driver.
> Bug fixes and improvements are not justification to create a new driver.

I was about to send a similar mail.
+1 on this nack.