mbox series

[v3,0/4] compressdev: add LZ4 support

Message ID 20230213061140.2157499-1-michaelba@nvidia.com (mailing list archive)
Headers
Series compressdev: add LZ4 support |

Message

Michael Baum Feb. 13, 2023, 6:11 a.m. UTC 
  Add support for LZ4 compression algorithm for both API and app.

In addition, enable app to test de/comp only. This option already
exists in both app doc and arguments but isn't implemented inside the
application.

LZ4: https://github.com/lz4/lz4
RFC:
https://patchwork.dpdk.org/project/dpdk/patch/20220410182622.8828-1-rzidane@nvidia.com/

v2:
 - Add macros for all LZ4 flags in the standard.
 - Rebase.

v3:
 - Rebase.

Michael Baum (4):
  compressdev: add LZ4 algorithm support
  app/test-compress-perf: allow test single compress operation
  app/test-compress-perf: add algo option
  app/test-compress-perf: add LZ4 support

 app/test-compress-perf/comp_perf_options.h    |   9 +-
 .../comp_perf_options_parse.c                 |  83 +++++++++++-
 .../comp_perf_test_common.c                   | 126 +++++++++++++-----
 .../comp_perf_test_cyclecount.c               |  82 +++++++-----
 .../comp_perf_test_throughput.c               |  75 +++++++----
 .../comp_perf_test_verify.c                   |  75 +++++++----
 app/test-compress-perf/main.c                 |  63 +++++++--
 doc/guides/compressdevs/features/default.ini  |   7 +
 doc/guides/rel_notes/release_23_03.rst        |  16 +++
 doc/guides/tools/comp_perf.rst                |   5 +
 lib/compressdev/rte_comp.c                    |  12 ++
 lib/compressdev/rte_comp.h                    |  79 ++++++++++-
 12 files changed, 488 insertions(+), 144 deletions(-)

Comments

Zhang, Fan Feb. 13, 2023, 3:47 p.m. UTC | #1 
Hi,

The patchset only have library change and added performance tests.

We shall have at least one PMD to support the added algorithms and unit 
test updated for the PMD/algorithms.

Regards,

Fan

On 2/13/2023 6:11 AM, Michael Baum wrote:
> Add support for LZ4 compression algorithm for both API and app.
>
> In addition, enable app to test de/comp only. This option already
> exists in both app doc and arguments but isn't implemented inside the
> application.
>
> LZ4: https://github.com/lz4/lz4
> RFC:
> https://patchwork.dpdk.org/project/dpdk/patch/20220410182622.8828-1-rzidane@nvidia.com/
>
> v2:
>   - Add macros for all LZ4 flags in the standard.
>   - Rebase.
>
> v3:
>   - Rebase.
>
> Michael Baum (4):
>    compressdev: add LZ4 algorithm support
>    app/test-compress-perf: allow test single compress operation
>    app/test-compress-perf: add algo option
>    app/test-compress-perf: add LZ4 support
>
>   app/test-compress-perf/comp_perf_options.h    |   9 +-
>   .../comp_perf_options_parse.c                 |  83 +++++++++++-
>   .../comp_perf_test_common.c                   | 126 +++++++++++++-----
>   .../comp_perf_test_cyclecount.c               |  82 +++++++-----
>   .../comp_perf_test_throughput.c               |  75 +++++++----
>   .../comp_perf_test_verify.c                   |  75 +++++++----
>   app/test-compress-perf/main.c                 |  63 +++++++--
>   doc/guides/compressdevs/features/default.ini  |   7 +
>   doc/guides/rel_notes/release_23_03.rst        |  16 +++
>   doc/guides/tools/comp_perf.rst                |   5 +
>   lib/compressdev/rte_comp.c                    |  12 ++
>   lib/compressdev/rte_comp.h                    |  79 ++++++++++-
>   12 files changed, 488 insertions(+), 144 deletions(-)
>
Michael Baum Feb. 13, 2023, 3:56 p.m. UTC | #2 
On 2/13/2023 17:47 PM, Zhang, Fan wrote: 
> Hi,
> 
> The patchset only have library change and added performance tests.
> 
> We shall have at least one PMD to support the added algorithms and unit test
> updated for the PMD/algorithms.

There is another patchset which adds it in MLX5 compress PMD:
series-26766 ("compress/mlx5: add LZ4 support") https://patchwork.dpdk.org/project/dpdk/cover/20230202162537.1067595-1-michaelba@nvidia.com/

> 
> Regards,
> 
> Fan
> 
> On 2/13/2023 6:11 AM, Michael Baum wrote:
> > Add support for LZ4 compression algorithm for both API and app.
> >
> > In addition, enable app to test de/comp only. This option already
> > exists in both app doc and arguments but isn't implemented inside the
> > application.
> >
> > LZ4: https://github.com/lz4/lz4
> > RFC:
> > https://patchwork.dpdk.org/project/dpdk/patch/20220410182622.8828-1-rz
> > idane@nvidia.com/
> >
> > v2:
> >   - Add macros for all LZ4 flags in the standard.
> >   - Rebase.
> >
> > v3:
> >   - Rebase.
> >
> > Michael Baum (4):
> >    compressdev: add LZ4 algorithm support
> >    app/test-compress-perf: allow test single compress operation
> >    app/test-compress-perf: add algo option
> >    app/test-compress-perf: add LZ4 support
> >
> >   app/test-compress-perf/comp_perf_options.h    |   9 +-
> >   .../comp_perf_options_parse.c                 |  83 +++++++++++-
> >   .../comp_perf_test_common.c                   | 126 +++++++++++++-----
> >   .../comp_perf_test_cyclecount.c               |  82 +++++++-----
> >   .../comp_perf_test_throughput.c               |  75 +++++++----
> >   .../comp_perf_test_verify.c                   |  75 +++++++----
> >   app/test-compress-perf/main.c                 |  63 +++++++--
> >   doc/guides/compressdevs/features/default.ini  |   7 +
> >   doc/guides/rel_notes/release_23_03.rst        |  16 +++
> >   doc/guides/tools/comp_perf.rst                |   5 +
> >   lib/compressdev/rte_comp.c                    |  12 ++
> >   lib/compressdev/rte_comp.h                    |  79 ++++++++++-
> >   12 files changed, 488 insertions(+), 144 deletions(-)
> >