diff mbox series

net/netvsc: increase VSP response timeout to 60 seconds

Message ID 1690410550-15636-1-git-send-email-longli@linuxonhyperv.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/netvsc: increase VSP response timeout to 60 seconds |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Long Li July 26, 2023, 10:29 p.m. UTC 
  From: Long Li <longli@microsoft.com>

The current timeout is set to 5 seconds. In Azure, tests show that it may
take up to 15 seconds for VSP to respond on busy nodes. The VSP schedules
unbounded work to process VSC resquest, there is no upper limit on how long
it takes to send response back to VSC.

In the NETVSC kernel mode driver, it waits forever for VSP response. While in
DPDK we can't wait forever, setting the timeout to 60 seconds.

Cc: stable@dpdk.org
Signed-off-by: Long Li <longli@microsoft.com>
---
 drivers/net/netvsc/hn_rndis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Sept. 28, 2023, 6:01 p.m. UTC | #1 
On 7/26/2023 11:29 PM, longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
> 
> The current timeout is set to 5 seconds. In Azure, tests show that it may
> take up to 15 seconds for VSP to respond on busy nodes. The VSP schedules
> unbounded work to process VSC resquest, there is no upper limit on how long
> it takes to send response back to VSC.
> 
> In the NETVSC kernel mode driver, it waits forever for VSP response. While in
> DPDK we can't wait forever, setting the timeout to 60 seconds.
> 
> Cc: stable@dpdk.org
> Signed-off-by: Long Li <longli@microsoft.com>
> 

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/drivers/net/netvsc/hn_rndis.c b/drivers/net/netvsc/hn_rndis.c
index e6f1f28768..7e9abce8d0 100644
--- a/drivers/net/netvsc/hn_rndis.c
+++ b/drivers/net/netvsc/hn_rndis.c
@@ -35,7 +35,7 @@ 
 #include "hn_rndis.h"
 #include "ndis.h"
 
-#define RNDIS_TIMEOUT_SEC 5
+#define RNDIS_TIMEOUT_SEC 60
 #define RNDIS_DELAY_MS    10
 
 #define HN_RNDIS_XFER_SIZE		0x4000