diff mbox series

[v4,33/39] compressdev: use C11 alignas

Message ID	1707928564-28796-34-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State	Superseded, archived
Delegated to:	David Marchand
Headers	From: Tyler Retzlaff <roretzla@linux.microsoft.com> To: dev@dpdk.org Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Bruce Richardson <bruce.richardson@intel.com>, Chengwen Feng <fengchengwen@huawei.com>, Cristian Dumitrescu <cristian.dumitrescu@intel.com>, David Christensen <drc@linux.vnet.ibm.com>, David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, Jasvinder Singh <jasvinder.singh@intel.com>, Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>, Sameh Gobriel <sameh.gobriel@intel.com>, Stanislaw Kardach <kda@semihalf.com>, Thomas Monjalon <thomas@monjalon.net>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>, Yipeng Wang <yipeng1.wang@intel.com>, Tyler Retzlaff <roretzla@linux.microsoft.com> Subject: [PATCH v4 33/39] compressdev: use C11 alignas Date: Wed, 14 Feb 2024 08:35:58 -0800 Message-Id: <1707928564-28796-34-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1707928564-28796-1-git-send-email-roretzla@linux.microsoft.com> References: <1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com> <1707928564-28796-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	use C11 alignas and normalize type alignment \| [v4,00/39] use C11 alignas and normalize type alignment [v4,01/39] eal: use C11 alignas [v4,02/39] eal: redefine macro to be integer literal for MSVC [v4,03/39] stack: use C11 alignas [v4,04/39] sched: use C11 alignas [v4,05/39] ring: use C11 alignas [v4,06/39] pipeline: use C11 alignas [v4,07/39] net: use C11 alignas [v4,08/39] mbuf: use C11 alignas [v4,09/39] hash: use C11 alignas [v4,10/39] eventdev: use C11 alignas [v4,11/39] ethdev: use C11 alignas [v4,12/39] dmadev: use C11 alignas [v4,13/39] distributor: use C11 alignas [v4,14/39] acl: use C11 alignas [v4,15/39] vhost: use C11 alignas [v4,16/39] timer: use C11 alignas [v4,17/39] table: use C11 alignas [v4,18/39] reorder: use C11 alignas [v4,19/39] regexdev: use C11 alignas [v4,20/39] rcu: use C11 alignas [v4,21/39] power: use C11 alignas [v4,22/39] rawdev: use C11 alignas [v4,23/39] port: use C11 alignas [v4,24/39] pdcp: use C11 alignas [v4,25/39] node: use C11 alignas [v4,26/39] mldev: use C11 alignas [v4,27/39] mempool: use C11 alignas [v4,28/39] member: use C11 alignas [v4,29/39] lpm: use C11 alignas [v4,30/39] ipsec: use C11 alignas [v4,31/39] jobstats: use C11 alignas [v4,32/39] bpf: use C11 alignas [v4,33/39] compressdev: use C11 alignas [v4,34/39] cryptodev: use C11 alignas [v4,35/39] dispatcher: use C11 alignas [v4,36/39] fib: use C11 alignas [v4,37/39] gpudev: use C11 alignas [v4,38/39] graph: use C11 alignas [v4,39/39] ip_frag: use C11 alignas

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Tyler Retzlaff Feb. 14, 2024, 4:35 p.m. UTC

* Move __rte_aligned from the end of {struct,union} definitions to
  be between {struct,union} and tag.

  The placement between {struct,union} and the tag allows the desired
  alignment to be imparted on the type regardless of the toolchain being
  used for all of GCC, LLVM, MSVC compilers building both C and C++.

* Replace use of __rte_aligned(a) on variables/fields with alignas(a).

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
 lib/compressdev/rte_comp.h                 | 4 ++--
 lib/compressdev/rte_compressdev_internal.h | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff mbox series

Patch

diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h
index 3606ebf..830a240 100644
--- a/lib/compressdev/rte_comp.h
+++ b/lib/compressdev/rte_comp.h
@@ -356,7 +356,7 @@  struct rte_comp_xform {
  * Comp operations are enqueued and dequeued in comp PMDs using the
  * rte_compressdev_enqueue_burst() / rte_compressdev_dequeue_burst() APIs
  */
-struct rte_comp_op {
+struct __rte_cache_aligned rte_comp_op {
 	enum rte_comp_op_type op_type;
 	union {
 		void *private_xform;
@@ -478,7 +478,7 @@  struct rte_comp_op {
 	 * will be set to RTE_COMP_OP_STATUS_SUCCESS after operation
 	 * is successfully processed by a PMD
 	 */
-} __rte_cache_aligned;
+};
 
 /**
  * Creates an operation pool
diff --git a/lib/compressdev/rte_compressdev_internal.h b/lib/compressdev/rte_compressdev_internal.h
index 01b7764..8a626d3 100644
--- a/lib/compressdev/rte_compressdev_internal.h
+++ b/lib/compressdev/rte_compressdev_internal.h
@@ -69,7 +69,7 @@  typedef uint16_t (*compressdev_enqueue_pkt_burst_t)(void *qp,
 		struct rte_comp_op **ops, uint16_t nb_ops);
 
 /** The data structure associated with each comp device. */
-struct rte_compressdev {
+struct __rte_cache_aligned rte_compressdev {
 	compressdev_dequeue_pkt_burst_t dequeue_burst;
 	/**< Pointer to PMD receive function */
 	compressdev_enqueue_pkt_burst_t enqueue_burst;
@@ -87,7 +87,7 @@  struct rte_compressdev {
 	__extension__
 	uint8_t attached : 1;
 	/**< Flag indicating the device is attached */
-} __rte_cache_aligned;
+};
 
 /**
  *
@@ -96,7 +96,7 @@  struct rte_compressdev {
  * This structure is safe to place in shared memory to be common among
  * different processes in a multi-process configuration.
  */
-struct rte_compressdev_data {
+struct __rte_cache_aligned rte_compressdev_data {
 	uint8_t dev_id;
 	/**< Compress device identifier */
 	int socket_id;
@@ -115,7 +115,7 @@  struct rte_compressdev_data {
 
 	void *dev_private;
 	/**< PMD-specific private data */
-} __rte_cache_aligned;
+};
 
 #ifdef __cplusplus
 }