diff mbox series

[1/2] eal/windows: do not install virt2phys header

Message ID 20211001163726.78308-2-dmitry.kozliuk@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series buildtools: enable chkincs on Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Dmitry Kozlyuk Oct. 1, 2021, 4:37 p.m. UTC 
  The header was not intended to be a public one.
DPDK users should use `rte_mem_virt2iova()` to translate addresses.
Other virt2phys users should use the header from the driver instead.

Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
Cc: stable@dpdk.org

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
 lib/eal/windows/include/meson.build | 1 -
 1 file changed, 1 deletion(-)

Comments

Thomas Monjalon Oct. 11, 2021, 7:07 p.m. UTC | #1 
01/10/2021 18:37, Dmitry Kozlyuk:
> The header was not intended to be a public one.
> DPDK users should use `rte_mem_virt2iova()` to translate addresses.
> Other virt2phys users should use the header from the driver instead.
> 
> Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
>  headers += files(
>          'rte_os.h',
> -        'rte_virt2phys.h',
>          'rte_windows.h',
>  )

We should plan to rename it.
Files starting with rte_ are supposed to be public.
Dmitry Kozlyuk Oct. 24, 2021, 9:58 p.m. UTC | #2 
2021-10-11 21:07 (UTC+0200), Thomas Monjalon:
> 01/10/2021 18:37, Dmitry Kozlyuk:
> > The header was not intended to be a public one.
> > DPDK users should use `rte_mem_virt2iova()` to translate addresses.
> > Other virt2phys users should use the header from the driver instead.
> > 
> > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
> >  headers += files(
> >          'rte_os.h',
> > -        'rte_virt2phys.h',
> >          'rte_windows.h',
> >  )  
> 
> We should plan to rename it.
> Files starting with rte_ are supposed to be public.

Is "rte_eal_" prefix OK for internal headers, like in "rte_eal_paging.h"?
I want to put NetUIO interface to EAL, but also to use it from bus/pci.
diff mbox series

Patch

diff --git a/lib/eal/windows/include/meson.build b/lib/eal/windows/include/meson.build
index b3534b025f..5fb1962ac7 100644
--- a/lib/eal/windows/include/meson.build
+++ b/lib/eal/windows/include/meson.build
@@ -5,6 +5,5 @@  includes += include_directories('.')
 
 headers += files(
         'rte_os.h',
-        'rte_virt2phys.h',
         'rte_windows.h',
 )