diff mbox series

[2/2] buildtools: enable chkincs on Windows

Message ID 20211001163726.78308-3-dmitry.kozliuk@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series buildtools: enable chkincs on Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing fail Testing issues
ci/iol-x86_64-compile-testing fail Testing issues
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Dmitry Kozlyuk Oct. 1, 2021, 4:37 p.m. UTC 
  Independent header compilation test (chkincs) was disabled on Windows.
The comment stated that the shebang line in the generator script was not
working. Meson 0.57.0, currently recommended for Windows, successfully
parses that line and invokes the script. Remove the OS restriction
as its reason no longer applies.

Fixes: 05050ac4ce99 ("build: add header includes check")
Cc: bruce.richardson@intel.com

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
 buildtools/chkincs/meson.build | 5 -----
 1 file changed, 5 deletions(-)

Comments

Bruce Richardson Oct. 1, 2021, 4:39 p.m. UTC | #1 
On Fri, Oct 01, 2021 at 07:37:26PM +0300, Dmitry Kozlyuk wrote:
> Independent header compilation test (chkincs) was disabled on Windows.
> The comment stated that the shebang line in the generator script was not
> working. Meson 0.57.0, currently recommended for Windows, successfully
> parses that line and invokes the script. Remove the OS restriction
> as its reason no longer applies.
> 
> Fixes: 05050ac4ce99 ("build: add header includes check")
> Cc: bruce.richardson@intel.com
> 
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
diff mbox series

Patch

diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build
index 34dcd81ce1..5ffca89761 100644
--- a/buildtools/chkincs/meson.build
+++ b/buildtools/chkincs/meson.build
@@ -6,11 +6,6 @@  if not get_option('check_includes')
     subdir_done()
 endif
 
-if is_windows
-    # for windows, the shebang line in the script won't work.
-    error('option "check_includes" is not supported on windows')
-endif
-
 gen_c_file_for_header = find_program('gen_c_file_for_header.py')
 gen_c_files = generator(gen_c_file_for_header,
         output: '@BASENAME@.c',