diff mbox series

[v2] common/cnxk: fix bp_ena clear while disabling aura

Message ID 20230825035721.2723124-1-asekhar@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [v2] common/cnxk: fix bp_ena clear while disabling aura |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

Ashwin Sekhar T K Aug. 25, 2023, 3:57 a.m. UTC 
  As done in FLR, similar to CQ disable, in process of
aura disable we need to explicitly clear BP_ENA in order to
deassert backpressure if it was earlier asserted.

Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations")

Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
---
 drivers/common/cnxk/roc_npa.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jerin Jacob Aug. 25, 2023, 5:52 a.m. UTC | #1 
On Fri, Aug 25, 2023 at 9:27 AM Ashwin Sekhar T K <asekhar@marvell.com> wrote:
>
> As done in FLR, similar to CQ disable, in process of
> aura disable we need to explicitly clear BP_ENA in order to
> deassert backpressure if it was earlier asserted.
>
> Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations")
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>

Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks

    common/cnxk: fix aura disable handling

    As done in FLR, similar to CQ disable, in process of
    aura disable we need to explicitly clear BP_ENA in order to
    deassert backpressure if it was earlier asserted.

    Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations")
    Cc: stable@dpdk.org

    Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
    Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
diff mbox series

Patch

diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c
index 3b9a70028b..20801739dc 100644
--- a/drivers/common/cnxk/roc_npa.c
+++ b/drivers/common/cnxk/roc_npa.c
@@ -185,6 +185,8 @@  npa_aura_pool_fini(struct mbox *m_box, uint32_t aura_id, uint64_t aura_handle)
 	aura_req->op = NPA_AQ_INSTOP_WRITE;
 	aura_req->aura.ena = 0;
 	aura_req->aura_mask.ena = ~aura_req->aura_mask.ena;
+	aura_req->aura.bp_ena = 0;
+	aura_req->aura_mask.bp_ena = ~aura_req->aura_mask.bp_ena;
 
 	rc = mbox_process(mbox);
 	if (rc < 0)