diff mbox series

event/sw: remove obsolete comment

Message ID 20230914093751.8170-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series event/sw: remove obsolete comment |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/loongarch-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS

Commit Message

Bruce Richardson Sept. 14, 2023, 9:37 a.m. UTC 
  Code that the comment refers to was previously removed, but the
comment remained.

Fixes: dca926ca9faa ("event/sw: use dynamically-sized IQs")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/event/sw/sw_evdev_scheduler.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Van Haaren, Harry Sept. 14, 2023, 10:10 a.m. UTC | #1 
> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Thursday, September 14, 2023 10:38 AM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; stable@dpdk.org
> Subject: [PATCH] event/sw: remove obsolete comment
> 
> Code that the comment refers to was previously removed, but the
> comment remained.
> 
> Fixes: dca926ca9faa ("event/sw: use dynamically-sized IQs")
> Cc: stable@dpdk.org

Do we want to backport this? It's a code-level change, that doesn't really "fix" any issue.
I'm fine with it being backported to stables, or skipped.

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

<snip>
Bruce Richardson Sept. 14, 2023, 10:29 a.m. UTC | #2 
On Thu, Sep 14, 2023 at 11:10:17AM +0100, Van Haaren, Harry wrote:
> > -----Original Message-----
> > From: Richardson, Bruce <bruce.richardson@intel.com>
> > Sent: Thursday, September 14, 2023 10:38 AM
> > To: dev@dpdk.org
> > Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Richardson, Bruce
> > <bruce.richardson@intel.com>; stable@dpdk.org
> > Subject: [PATCH] event/sw: remove obsolete comment
> > 
> > Code that the comment refers to was previously removed, but the
> > comment remained.
> > 
> > Fixes: dca926ca9faa ("event/sw: use dynamically-sized IQs")
> > Cc: stable@dpdk.org
> 
> Do we want to backport this? It's a code-level change, that doesn't really "fix" any issue.
> I'm fine with it being backported to stables, or skipped.
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> 

I'd take the view that since backporting is going to be entirely harmless,
and it does fix the code for anyone trying to read it, we might as well do so.
Stephen Hemminger Sept. 15, 2023, 3:12 p.m. UTC | #3 
On Thu, 14 Sep 2023 10:37:51 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> Code that the comment refers to was previously removed, but the
> comment remained.
> 
> Fixes: dca926ca9faa ("event/sw: use dynamically-sized IQs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Jerin Jacob Sept. 19, 2023, 2:05 p.m. UTC | #4 
On Fri, Sep 15, 2023 at 8:43 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Thu, 14 Sep 2023 10:37:51 +0100
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > Code that the comment refers to was previously removed, but the
> > comment remained.
> >
> > Fixes: dca926ca9faa ("event/sw: use dynamically-sized IQs")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>


Applied to dpdk-next-net-eventdev/for-main. Thanks
diff mbox series

Patch

diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c
index de6ed21643..17953fde0e 100644
--- a/drivers/event/sw/sw_evdev_scheduler.c
+++ b/drivers/event/sw/sw_evdev_scheduler.c
@@ -368,12 +368,6 @@  __pull_port_lb(struct sw_evdev *sw, uint32_t port_id, int allow_reorder)
 		if (!allow_reorder && !eop)
 			flags = QE_FLAG_VALID;
 
-		/*
-		 * if we don't have space for this packet in an IQ,
-		 * then move on to next queue. Technically, for a
-		 * packet that needs reordering, we don't need to check
-		 * here, but it simplifies things not to special-case
-		 */
 		uint32_t iq_num = PRIO_TO_IQ(qe->priority);
 		struct sw_qid *qid = &sw->qids[qe->queue_id];