diff mbox series

[v2] net/iavf: fix Tx offloading flags check

Message ID 20231025091258.10936-1-radu.nicolau@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series [v2] net/iavf: fix Tx offloading flags check |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Radu Nicolau Oct. 25, 2023, 9:12 a.m. UTC 
  Relax the check in the previous fix to allow packets
with security offload flag set.

Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading")
Cc: stable@dpdk.org
Cc: david.marchand@redhat.com

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
v2: extend the check for only TX_SEC_OFFLOAD

 drivers/net/iavf/iavf_rxtx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

David Marchand Oct. 26, 2023, 8:07 a.m. UTC | #1 
On Wed, Oct 25, 2023 at 11:13 AM Radu Nicolau <radu.nicolau@intel.com> wrote:
>
> Relax the check in the previous fix to allow packets
> with security offload flag set.
>
> Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading")
> Cc: stable@dpdk.org
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>

Acked-by: David Marchand <david.marchand@redhat.com>
Qi Zhang Oct. 30, 2023, 12:19 a.m. UTC | #2 
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Thursday, October 26, 2023 4:08 PM
> To: Nicolau, Radu <radu.nicolau@intel.com>
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> dev@dpdk.org; stable@dpdk.org
> Subject: Re: [PATCH v2] net/iavf: fix Tx offloading flags check
> 
> On Wed, Oct 25, 2023 at 11:13 AM Radu Nicolau <radu.nicolau@intel.com>
> wrote:
> >
> > Relax the check in the previous fix to allow packets with security
> > offload flag set.
> >
> > Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> 
> Acked-by: David Marchand <david.marchand@redhat.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
> 
> 
> --
> David Marchand
diff mbox series

Patch

diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index c6ef6af1d8..99007676a8 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -2664,7 +2664,8 @@  iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1,
 		l2tag1 |= m->vlan_tci;
 	}
 
-	if ((m->ol_flags & IAVF_TX_CKSUM_OFFLOAD_MASK) == 0)
+	if ((m->ol_flags &
+	    (IAVF_TX_CKSUM_OFFLOAD_MASK | RTE_MBUF_F_TX_SEC_OFFLOAD)) == 0)
 		goto skip_cksum;
 
 	/* Set MACLEN */