Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129931/?format=api
{ "id": 129931, "url": "http://patchwork.dpdk.org/api/patches/129931/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/MR1P264MB172997D1815F2F49AA6AB6A7D00CA@MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<MR1P264MB172997D1815F2F49AA6AB6A7D00CA@MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM>", "list_archive_url": "https://inbox.dpdk.org/dev/MR1P264MB172997D1815F2F49AA6AB6A7D00CA@MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM", "date": "2023-08-07T06:18:43", "name": "[TEST] dpdk/app/test/test_mbuf.c test_refcnt_mbuf instability + fix proposal", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "382345893285d7019406f3ecb39999c4ca402fe2", "submitter": { "id": 3143, "url": "http://patchwork.dpdk.org/api/people/3143/?format=api", "name": "Julien Hascoet", "email": "jhascoet@kalrayinc.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/MR1P264MB172997D1815F2F49AA6AB6A7D00CA@MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM/mbox/", "series": [ { "id": 29120, "url": "http://patchwork.dpdk.org/api/series/29120/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29120", "date": "2023-08-07T06:18:43", "name": "[TEST] dpdk/app/test/test_mbuf.c test_refcnt_mbuf instability + fix proposal", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29120/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/129931/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/129931/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9590242FF6;\n\tMon, 7 Aug 2023 08:18:47 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4AE9B410D3;\n\tMon, 7 Aug 2023 08:18:47 +0200 (CEST)", "from smtpout30.security-mail.net (smtpout30.security-mail.net\n [85.31.212.37]) by mails.dpdk.org (Postfix) with ESMTP id 8D16440A8B\n for <dev@dpdk.org>; Mon, 7 Aug 2023 08:18:45 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n by fx301.security-mail.net (Postfix) with ESMTP id 6C858A84C59\n for <dev@dpdk.org>; Mon, 7 Aug 2023 08:18:45 +0200 (CEST)", "from fx301 (localhost [127.0.0.1]) by fx301.security-mail.net\n (Postfix) with ESMTP id 4EF58A8519A for <dev@dpdk.org>; Mon, 7 Aug 2023\n 08:18:45 +0200 (CEST)", "from FRA01-MR2-obe.outbound.protection.outlook.com\n (mail-mr2fra01lp0105.outbound.protection.outlook.com [104.47.25.105]) by\n fx301.security-mail.net (Postfix) with ESMTPS id CE1C0A85035 for\n <dev@dpdk.org>; Mon, 7 Aug 2023 08:18:44 +0200 (CEST)", "from MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:5::17)\n by MR1P264MB2387.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Mon, 7 Aug\n 2023 06:18:43 +0000", "from MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM\n ([fe80::77f5:4fc5:a7f9:f855]) by MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM\n ([fe80::77f5:4fc5:a7f9:f855%7]) with mapi id 15.20.6652.026; Mon, 7 Aug 2023\n 06:18:43 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=kalrayinc.com;\n s=sec-sig-email; t=1691389125;\n bh=zeTQSzPnojzD/5CbjvJhPyegcrgJQ+8bBP+nhn/Qd1k=;\n h=From:To:Subject:Date;\n b=Ik1mu4z/mfX5hrDHHjmT9MliAUt+z8rfHT2M3tNvobb0VFrQKuwkCuqdvyfJ4DI1y\n L/DNs5CceYUVroagMQJIEpV+gKFvugNnhgR5CsYjF0Ds0nWPFXSkrJKQHZkZiaZ5Fd\n kvbtn/YN0eRIo1DRbniz/9OHyryTTiQl9IvizwQ4=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=kalrayinc.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=VvCLtcdxRtyJajICt+quDaJELE/WyqhHK11RbsFPR/w=;\n b=Aja4FRcvVDkP4cbllPxMjLBcRXrUxb7zB3U51ladWKzF+jvwnXse5kQkJfxNzFMv8P7ajh+YHoMK/EzT7d8bjIlBPBjgwTp/YR3pm9GgAPTOxjEtxdTSnQAdrhf2RWPO3BsiRCVjXURX/3xSme3DF8BJWGcEFgAJgKWbS1vi6zrbIRYpcfRgKcvyavYDwnWwKFdxkzFiVDHGVn2/lHgfsKjJ40sA4c82OOkr035hzemu3dqriGYjWMhroRWNjIO+b4e7GLEq+vV2jPs+z2Mw1nIN7FTOUBUtnPRiLyr8QkBPMlc4jOvPa+MFnvzp3jO67w5bQSONIkqYNh1TEYLEyg==" ], "X-Virus-Scanned": "E-securemail", "Secumail-id": "<c49.64d08cc4.cd93e.0>", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=oEIchv2I5DsMtcJ8Ih6UNWLFms72+AxqBqBWP3aEArfpXVc5+OV18uYlE6GQqDQntYDT6coa+mh6ew3L1d+Q+5/ernV30sTU5lPqAl4wmXv3xFB0jeyzfNvK8phJyebGIUFcDZ+hpWwoW+659J1dAnZ6OUIddaHfiPVEe6Smu2NY3jcgqpGUTiVH2FkUAunPgYKPhfq+xr1tlNbY2orYoZ4JbYUwL5DG61ZSqf55SqqC1sunIjrY25MIe+5DxpoPedClO4o4IzUahWp0hNPDkwtR+j84f6JZH1v7TRhmlL85rLC3Tz7A5ULbBlyB+dzOpiP6WRoCJz3OKtwL1Amr4Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed;\n d=microsoft.com; s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=VvCLtcdxRtyJajICt+quDaJELE/WyqhHK11RbsFPR/w=;\n b=h9WYxxGi1dkUr+b3WVBem4jKQLssBIcNYIcmRFL3kMyHm1k9DZDkh+4Cfwxj3ICIeHsIG3w/n7kF8ckZ4N7OCS15YCoj3F1BSPkfUEIbnid7tnhI4UlqHzFY4aa5/sEIv64Dybj5TL+AZ57ajKxCZfoj0UEzV28Z0Pil+rNwPXG5pxP7qX0CxJ9bYxeUA1IQsfj88ky4tw/rtb8dGlTvM/e/dZ9F9kkvzarlQZ9BunNq7DWyIPU9qP4UYcVh/1hWY8BHmnJf2n1c8+L4emef+C/XIrycRgW70cSClugjvCnGSITNkeDZqfKdbMR2fUCN3QlNv9QeY52NVhv+Jit5OQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=kalrayinc.com; dmarc=pass action=none\n header.from=kalrayinc.com; dkim=pass header.d=kalrayinc.com; arc=none", "From": "Julien Hascoet <jhascoet@kalrayinc.com>", "To": "dev@dpdk.org", "Subject": "[TEST] dpdk/app/test/test_mbuf.c test_refcnt_mbuf instability + fix\n proposal", "Thread-Topic": "[TEST] dpdk/app/test/test_mbuf.c test_refcnt_mbuf instability\n + fix proposal", "Thread-Index": "AQHZyPXqJYRcwSX/10G/C+IoeOYWlg==", "Date": "Mon, 7 Aug 2023 06:18:43 +0000", "Message-ID": "\n <MR1P264MB172997D1815F2F49AA6AB6A7D00CA@MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM>", "Accept-Language": "fr-FR, en-GB, en-US", "Content-Language": "fr-fr", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "msip_labels": "", "authentication-results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=kalrayinc.com;", "x-ms-publictraffictype": "Email", "x-ms-traffictypediagnostic": "MR1P264MB1729:EE_|MR1P264MB2387:EE_", "x-ms-office365-filtering-correlation-id": "47605b6e-365c-496c-2720-08db970e2661", "x-ms-exchange-senderadcheck": "1", "x-ms-exchange-antispam-relay": "0", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n cZmSMSldCvwHaCZrJhN8DE4dYY6dSHE2HUZCzFFJVyVYULKmQFR39iXbCekZXX/TJvauHfsS0F+eOELeQgl2K6ott9CLTV3Rd16aMftK7G+SAynkacrzzPLR9mKptiRfvxSbu6iJQZ+6q7aXlsYhYGv6sucjUs4gQUblj1K21kd+gLSBD3p3IOWbxRhSt/4619YDGEt3nSeaaid2GcKUK4J2/N0qVcPeyUqapMaT43SVaAFd8M28CE8OrmwtNTA90R7nbwRUtfsSOXE608gvvheqzfmzfFBEjhIuoNjk5vLWDXriB1HwpBf9e+J1CJ7k5TggQ/gCmN0AH/RoV1WwvYGREQpx6heOUBDL5/4OSwe0gGbfePoJS2/wBGJuf5Ym5X9fqL9hQc2GC3dp9J3c0DecJ2dpPd61NvnP5fggfIHDP0yfSwcJB/MWOM4jwd/PXE0eiGuXqz/sOctCsLX4KmInwfjOT/cyvEIAUnHORNd7tIydksEQVWmsrSxIqCtunCEPi4kpMnJSef2gsw+QlsEMpbjtgJQrulW59ZRazHtUdwbx+au5GkO6+1brlJDMs1l/aaw9/BqTfdv5J1Yzjjc3UVD9x41MeVm15oOUDbYhfYMaXcNsrkp/zmMiIAmv", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230028)(4636009)(39860400002)(136003)(396003)(346002)(376002)(366004)(451199021)(186006)(1800799003)(55016003)(19627405001)(9686003)(316002)(6916009)(86362001)(122000001)(478600001)(38100700002)(76116006)(71200400001)(66946007)(91956017)(64756008)(66556008)(66476007)(66446008)(33656002)(7696005)(6506007)(41300700001)(26005)(52536014)(38070700005)(8676002)(8936002)(4744005)(2906002)(83380400001)(5660300002);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata-chunkcount": "1", "x-ms-exchange-antispam-messagedata-0": "\n VGdX8gvsxVCKZY2ZgtUWPy6bhjP8YacnuPgNOS60shMd1jBISsPK1jeNcQ9H8o2pUb0/ey/q76ftKK4oSh/hrWR3Wb7dsXB5xJHEjYYWh97rhsyYtsqQvILQcEE2gwYPnFukpTUfGQgDpzK0jeqBl+Dx2Z3DcVvG4u2Tl/E2TaC0dv8NL+i2+wBFr4Pe2v+wVVakNco6S3272UVk4fvVixsXnWy1g/pFDU+Z9SHoFM504NsvCotHLpmfMIVBvjyBO9pEDlFT/CAAhix+ipF7ToayHDDUPa2pcqfUqvo9RRLDJ0whenXK3bYa6tBoGusTp/p0YkDzVLiGTuO/FY2vd7ICKEkuCk6OtlWbJb8pHDN2iQW0X8rB8z/TNdrs4gLihow3+oM+8Uh4UyI/yBxCWUBY1Ee7uRYcnQmxEyRp9GKgFvAGlw1csZz8ujLeOIAwDGGDK8pEwcY/WeV3Kl79IesvbxLPCn9vmIJUpsRRoFTS6/QgrJfScjL2AlaULyr/NRn50U10cEUG5wCj1tcPHU6Werw8jhuHEHizR+RdDpsMDR2lMccDl2Qya19nZ7SXDtez3Xvb7wCiK+Cyw6XUo8Y4DnIWiSVdYcJecAzBRs6FL49GiR/pXNPFFoGyy8qUovqGISBeqOso+sPvM7bl0+3YERKPCttrStTlyHM6xUYjbtm+WWQ8JMrZYvpAEF3ST7/IwwiNpRZEfN9UO1yAJFmT3ddG1gcnSYlwU2Ogda6435XmyXclXbTQeL8ux0d8Hc7wOQoIN1AQTYrUubPd8hm0sao3z8GdZHOTqT1aBbgaMfGFwbMxpTYObn5iJ4n5IYYlGWnagA49hxggaKGXovmWjBjtKWMykL8tbegc9V9Q0AHNLyYleS4JY3yg53uSmQAhBZhUIs76tMR/h5PcJrlbLTpMNL96qCtorePW9qE4HBAvLpgT7HUTa2oVWRtn\n t+hQ4U2ELnHX/fwJG2ipx4doBVA1Z6NJNxdw4YRN00RxrLK2oAMM5+ZGuJWwikcT4Cz6uFdmoLz2ttkSzHDEmyOfZCVBKILEGtN6lQ/KF+aOv2AYq035FpZFPtDTTLxKXX1rBLiOTOUwke8tZ1OYldge85mfnN45mJJTDvI/pwPFvdrBpLxixr5l4rggd8cfqyE8Ym8+mvHDB6ZJxqQHbLlf6EuPaRljn5bYmFzF2beaK4LQkJDOrXCBgi87kAPbFtM9M7tJdJvi9+r4RuiiX6JVyctETKSNKKnsw7j1F4M0XZPidZvW1e7txr9xtkPbyNusNj0y1G251UNTMC8aIc+hCDOfkGQrWiPX7FxnZvZ/Lag9aAe3ktA+ZuijiS1abNLtvgTnqVRBArfPY0lj8pbARBeMv5sONYpRW3QXFY3/9/pkWFyJ7a07rQnRw0UqQZ14GzUwF5KJaiBh+m+zxTyyqi567pxGC0K5Z0jOaRA+hvjk1cSnKbBIL6JfLQI7CEuBUD5Fvn+ZAxjyTz70rLjYEm6GnEbVf3Ze4Yuq4VTynlzmn1g9SFghgMZfHttwDtbSD0X1QL9sreNGaDbFe3f7NCJkGIKjNCudASAhvVokNPjrCRLF++H9DfM/ej6D", "Content-Type": "multipart/alternative;\n boundary=secu_7ef32551bcbfca0959b816391e302851_part1", "MIME-Version": "1.0", "X-OriginatorOrg": "kalrayinc.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 47605b6e-365c-496c-2720-08db970e2661", "X-MS-Exchange-CrossTenant-originalarrivaltime": "07 Aug 2023 06:18:43.1920 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "8931925d-7620-4a64-b7fe-20afd86363d3", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n fmeQ7v3muCe2BKIzH0ZBlAZTmsUhPS3TEYMp+2OCLPiBiMlMzBDGiWt3ef5zZUviGA1HRQdivwHM1KJV+6OH0g==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MR1P264MB2387", "X-ALTERMIMEV2_out": "done", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Hello,\n\nfrom my understanding after debugging, in test_refcnt_iter the return value of rte_ring_enqueue is not checked; leading to lack of expected mbufs at the end checks.\n\nHere is some fix proposal that seems to work after running endurance tests for several days:\n\n\nCan you confirm ?\n\nThank,\n\nJulien Hascoet", "diff": "diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c\nindex b4f436b5e2..8a5d26e4f6 100644\n--- a/app/test/test_mbuf.c\n+++ b/app/test/test_mbuf.c\n@@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter,\n tref += ref;\n if ((ref & 1) != 0) {\n rte_pktmbuf_refcnt_update(m, ref);\n- while (ref-- != 0)\n- rte_ring_enqueue(refcnt_mbuf_ring, m);\n+ while (ref-- != 0) {\n+ /* retry in case of failure */\n+ while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)\n+ ;\n+ }\n } else {\n while (ref-- != 0) {\n rte_pktmbuf_refcnt_update(m, 1);\n- rte_ring_enqueue(refcnt_mbuf_ring, m);\n+ /* retry in case of failure */\n+ while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)\n+ ;\n }\n }\n rte_pktmbuf_free(m);\n", "prefixes": [ "TEST" ] }