diff mbox series

[v2,02/16] bus/dpaa: verify strdup return value

Message ID	20231110100117.8350-3-fengchengwen@huawei.com (mailing list archive)
State	Accepted, archived
Delegated to:	Thomas Monjalon
Headers	From: Chengwen Feng <fengchengwen@huawei.com> To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@nxp.com>, Shreyansh Jain <shreyansh.jain@nxp.com> CC: <dev@dpdk.org> Subject: [PATCH v2 02/16] bus/dpaa: verify strdup return value Date: Fri, 10 Nov 2023 10:01:03 +0000 Message-ID: <20231110100117.8350-3-fengchengwen@huawei.com> In-Reply-To: <20231110100117.8350-1-fengchengwen@huawei.com> References: <20231110100117.8350-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	verify strdup return value \| [v2,00/16] verify strdup return value [v2,01/16] eal: verify strdup return value [v2,02/16] bus/dpaa: verify strdup return value [v2,03/16] bus/fslmc: verify strdup return value [v2,04/16] bus/vdev: verify strdup return value [v2,05/16] dma/idxd: verify strdup return value [v2,06/16] event/cnxk: verify strdup return value [v2,07/16] net/failsafe: fix memory leak when parse args [v2,08/16] net/nfp: verify strdup return value [v2,09/16] app/dumpcap: verify strdup return value [v2,10/16] app/pdump: verify strdup return value [v2,11/16] app/test: verify strdup return value [v2,12/16] app/test-crypto-perf: verify strdup return value [v2,13/16] app/test-dma-perf: verify strdup return value [v2,14/16] app/testpmd: verify strdup return value [v2,15/16] examples/qos_sched: fix memory leak when parse args [v2,16/16] examples/vhost: verify strdup return value

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

fengchengwen Nov. 10, 2023, 10:01 a.m. UTC

  Add verify strdup return value logic.

Fixes: e79df833d3f6 ("bus/dpaa: support hotplug ops")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 drivers/bus/dpaa/dpaa_bus.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Sachin Saxena Nov. 15, 2023, 2:43 a.m. UTC | #1

Acked-by: Sachin Saxena <sachin.saxena@nxp.com>

> -----Original Message-----
> From: Chengwen Feng <fengchengwen@huawei.com>
> Sent: 10 November 2023 03:31 PM
> To: thomas@monjalon.net; ferruh.yigit@amd.com; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com>;
> Shreyansh Jain <shreyansh.jain@nxp.com>
> Cc: dev@dpdk.org
> Subject: [PATCH v2 02/16] bus/dpaa: verify strdup return value
> 
> Add verify strdup return value logic.
> 
> Fixes: e79df833d3f6 ("bus/dpaa: support hotplug ops")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
>  drivers/bus/dpaa/dpaa_bus.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index
> e57159f5d8..a67f5c9ab5 100644
> --- a/drivers/bus/dpaa/dpaa_bus.c
> +++ b/drivers/bus/dpaa/dpaa_bus.c
> @@ -791,6 +791,10 @@ dpaa_bus_dev_iterate(const void *start, const char
> *str,
> 
>  	/* Now that name=device_name format is available, split */
>  	dup = strdup(str);
> +	if (dup == NULL) {
> +		DPAA_BUS_DEBUG("Dup string (%s) failed!\n", str);
> +		return NULL;
> +	}
>  	dev_name = dup + strlen("name=");
> 
>  	if (start != NULL) {
> --
> 2.17.1

diff mbox series

Patch

diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c
index e57159f5d8..a67f5c9ab5 100644
--- a/drivers/bus/dpaa/dpaa_bus.c
+++ b/drivers/bus/dpaa/dpaa_bus.c
@@ -791,6 +791,10 @@  dpaa_bus_dev_iterate(const void *start, const char *str,
 
 	/* Now that name=device_name format is available, split */
 	dup = strdup(str);
+	if (dup == NULL) {
+		DPAA_BUS_DEBUG("Dup string (%s) failed!\n", str);
+		return NULL;
+	}
 	dev_name = dup + strlen("name=");
 
 	if (start != NULL) {